Skip to content

Fix String creation to treat a modified UTF8 zero as ASCII - #19287

Merged
dmitripivkine merged 1 commit into
eclipse-openj9:masterfrom
pshipton:latin
Apr 10, 2024
Merged

Fix String creation to treat a modified UTF8 zero as ASCII#19287
dmitripivkine merged 1 commit into
eclipse-openj9:masterfrom
pshipton:latin

Conversation

@pshipton

@pshipton pshipton commented Apr 9, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Updates j9gc_createJavaLangString().

Fixes #19273

@pshipton

pshipton commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

jenkins test sanity,sanity.openjdk amac jdk11,jdk17

@pshipton

pshipton commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

jenkins test sanity alinux jdk8

@pshipton

pshipton commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

Opened #19289 for the jdk8 test problem.

@pshipton

pshipton commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

jenkins test sanity alinux jdk8

keithc-ca
keithc-ca requested changes Apr 10, 2024
View reviewed changes
Comment thread runtime/gc_base/StringTable.cpp Outdated
Comment thread runtime/gc_base/StringTable.cpp Outdated
Comment thread runtime/gc_base/StringTable.cpp Outdated
@pshipton

pshipton commented Apr 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

The jdk8 alinux PR test https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5342/ - passed

And jdk11, 17 PR testing https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/5337/ - passed

@pshipton
pshipton force-pushed the latin branch 2 times, most recently from c9f2809 to 0ed99fe Compare April 10, 2024 14:32
@pshipton

pshipton commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

All the testing passed, the recent changes shouldn't affect that.

@pshipton

pshipton commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

Actually, I'll update the test suite to include the case that fails without this change.

@pshipton
Fix String creation to treat a modified UTF8 zero as ASCII
adad410 
Updates j9gc_createJavaLangString().

Issue eclipse-openj9#19273

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton

pshipton commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

Grinders on the updated test.

8: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3464/ - passed
11: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3465/ - passed
17: https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3466/ - passed

Grinder on jdk11 head stream
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3468/ - failed test_lastIndexOf3 as expected

@dmitripivkine
dmitripivkine merged commit fb87224 into eclipse-openj9:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes
@dmitripivkine dmitripivkine dmitripivkine approved these changes

Assignees

No one assigned

Labels

comp:vm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug in String.lastIndexOf with NULL character in Semeru 11.0.21 and 11.0.22

3 participants

@pshipton @keithc-ca @dmitripivkine