Fix acquireVMaccessIfNeeded for Non-Compiler Threads - #19260
Merged
Conversation
Contributor
Author
|
@mpirvu Could you please review? |
Contributor
Author
is one legimate place where the app thread does not have VMAccess, but startPCIfAlreadyCompiled tries to acquire VMAccess via TR::VMAccessCriticalSection.
|
mpirvu
reviewed
Apr 3, 2024
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
The code needs to take into the account the fact that TR_DisableNoVMAccess is an option that only applies to compilation threads. Looks good otherwise.
Whena a non-comp thread invokes acquireVMaccessIfNeeded, the function silently returns, because it assumes that a non-comp thread should already have had VMAccess. This is particularly problematic when using TR::VMAccessCriticalSection, as it is not at all obvious that the current thread may not actually have VMAccess. Furthermore, there are legitmate circusmtances when a non-comp thread will not have VMAccess and will need to use this API to acquire it. Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
mpirvu
approved these changes
Apr 3, 2024
Contributor
|
jenkins test sanity all jdk17 |
Contributor
Author
|
zlinux failure due to #17474 |
Contributor
Author
|
xlinux errors are due to #19114 |
Contributor
|
aarch64 tests aborted for no apparent reason: |
Contributor
Author
|
The build failed because |
Contributor
Author
|
jenkins test sanity alinux64 jdk17 |
Contributor
|
Test failure on aarch64: |
Contributor
Not sure if these are hangs, or the machine is just too slow. |
Member
|
For aarch64 cent8, it seems like these machines became slow. These are the aarch64 jobs |
Member
|
It's a network problem and I've disabled the problematic machines for now. jenkins test sanity alinux64 jdk17 |
Contributor
|
Merging since there are no issues cause this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a non-comp thread invokes
acquireVMaccessIfNeeded, the functionsilently returns, because it assumes that a non-comp thread should
already have had VMAccess. This is particularly problematic when using
TR::VMAccessCriticalSection, as it is not at all obvious that thecurrent thread may not actually have VMAccess. Furthermore, there are
legitmate circusmtances when a non-comp thread will not have VMAccess
Additionally, this PR includes:
compileMethodTR::VMAccessCriticalSectionindumpIPBCDataCallGraphEnables #18982