Skip to content

CRIU timer time compensation tests use TestResult.lockStatus - #19112

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:criutesttimeout
Apr 10, 2024
Merged

CRIU timer time compensation tests use TestResult.lockStatus#19112
tajila merged 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:criutesttimeout

Conversation

@JasonFengJ9

@JasonFengJ9 JasonFengJ9 commented Mar 8, 2024

Copy link
Copy Markdown
Member

CRIU timer time compensation tests use TestResult.lockStatus

Remove hard-coded Thread.sleep();
Check TestResult.lockStatus.get() == 0 if the time task thread finished;
Specify unusedArgument for criuScript.sh unused parameter $5 - the APP ARGS;
Enable KEEP_TEST_OUTPUT for testMillisDelayBeforeCheckpointDone and testMillisDelayAfterCheckpointDone.

Related to

The initial time-out occurred at

[ERR] /home/jenkins/workspace/Test_openjdk22_j9_sanity.functional_aarch64_linux_Release_testList_1/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/criu/criuScript.sh: line 41: 991547 Killed

There was little diagnosis info, this PR also added trace points and kept the test output file.

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9 JasonFengJ9 added comp:test criu Used to track CRIU snapshot related work labels Mar 8, 2024
@JasonFengJ9
JasonFengJ9 requested a review from tajila March 8, 2024 22:14
@tajila

tajila commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity xlinux jdk17

@tajila

tajila commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity plinux jdk21

@tajila

tajila commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity zlinux jdk17

@JasonFengJ9

JasonFengJ9 commented Apr 5, 2024

Copy link
Copy Markdown
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_sanity.functional_x86-64_linux_Personal_testList_0/471/consoleFull

13:00:20 [OUT] pie: 15232: Error (criu/pie/restorer.c:1839): prctl failed @1839 with -1

This seems a known failure

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/448/consoleFull

11:49:16  Testing: -XX:-HandleSIGXFSZ -Xrs (Linux)
11:49:16  Test start time: 2024/04/04 15:49:16 Coordinated Universal Time
11:49:16  Running command: sh /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdLineTests/sigxfszHandlingTest/runSIGXFSZTest.sh ""/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java"   -Xshareclasses:none -cp "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdline_options_testresources/cmdlinetestresources.jar" -XX:-HandleSIGXFSZ -Xrs j9vm.test.sigxfsz.SignalXfszTest test.txt"
11:49:16  Time spent starting: 5 milliseconds
11:49:16  Time spent executing: 31 milliseconds
11:49:16  Test result: FAILED
11:49:16  Output from test:
11:49:16   [OUT] 4000
11:49:16   [OUT] Running: /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java -Xshareclasses:none -cp /home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/aqa-tests/TKG/../../jvmtest/functional/cmdline_options_testresources/cmdlinetestresources.jar -XX:-HandleSIGXFSZ -Xrs j9vm.test.sigxfsz.SignalXfszTest test.txt
11:49:16   [ERR] File size limit exceeded
11:49:16  >> Required condition was not found: [Output match: Starting SignalXfszTest]
11:49:16  >> Failure condition was not found: [Output match: Failed to write the file:]
11:49:16  >> Failure condition was not found: [Output match: File is written successfully]
11:49:16  >> Failure condition was not found: [Output match: Unhandled Exception]
11:49:16  >> Failure condition was not found: [Output match: Exception:]
11:49:16  >> Failure condition was not found: [Output match: corrupt]
11:49:16  >> Failure condition was not found: [Output match: Processing dump event]
11:49:16  >> Success condition was found: [Return code: 153]
11:49:16  
11:49:16  
11:49:16  ---TEST RESULTS---
11:49:16  Number of PASSED tests: 5 out of 8
11:49:16  Number of FAILED tests: 3 out of 8
11:49:16  
11:49:16  ---SUMMARY OF FAILED TESTS---
11:49:16  -XX:-HandleSIGXFSZ (Linux)
11:49:16  -XX:+HandleSIGXFSZ -XX:-HandleSIGXFSZ (Linux)
11:49:16  -XX:-HandleSIGXFSZ -Xrs (Linux)
11:49:16  -----------------------------
11:49:16  
11:49:16  -----------------------------------
11:49:16  cmdLineTest_sigxfszHandlingTest_0_FAILED

10:42:22  Testing: APITests.URLStoreFindTest
10:42:23  Test start time: 2024/04/04 14:42:22 Coordinated Universal Time
10:42:23  Running command: "/home/jenkins/workspace/Test_openjdk17_j9_sanity.functional_s390x_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java"  -Xcompressedrefs -Xjit -Xgcpolicy:gencon  -Xshareclasses:name=URLHelperTests --add-modules openj9.sharedclasses --add-exports java.base/Utilities=ALL-UNNAMED --add-reads java.base=openj9.sharedclasses --patch-module java.base=./Utils:. APITests.URLStoreFindTest
10:42:23  Time spent starting: 14 milliseconds
10:42:24  Time spent executing: 2000 milliseconds
10:42:24  Test result: FAILED
10:42:24   [OUT] java.io.UncheckedIOException: java.nio.file.NoSuchFileException: ./omrvmem_001631276_6nptOD
10:42:24   [OUT] Caused by: java.nio.file.NoSuchFileException: ./omrvmem_001631276_6nptOD
10:42:24  >> Success condition was not found: [Output match: TEST PASSED]
10:42:24  >> Failure condition was not found: [Output match: Error:]
10:42:24  >> Failure condition was not found: [Output match: Unhandled Exception]
10:42:24  >> Failure condition was found: [Output match: Exception:]

10:43:11  ---TEST RESULTS---
10:43:11  Number of PASSED tests: 25 out of 26
10:43:11  Number of FAILED tests: 1 out of 26
10:43:11  
10:43:11  ---SUMMARY OF FAILED TESTS---
10:43:11  APITests.URLStoreFindTest
10:43:11  -----------------------------
10:43:11  
10:43:11  -----------------------------------
10:43:11  cmdLineTester_SCURLHelperTests_90_1_FAILED

Interestingly a nightly build passed a grinder https://openj9-jenkins.osuosl.org/job/Grinder/3448/console, looking into why this PR build failed.

@pshipton

pshipton commented Apr 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We just got a -XX:-HandleSIGXFSZ failure on vmfarm FYI, on ub16 machines. Not sure why this just started.
#19276

@JasonFengJ9
CRIU timer time compensation tests use TestResult.lockStatus
76b3fb6 
Remove hard-coded Thread.sleep();
Check TestResult.lockStatus.get() == 0 if the time task thread finished;
Specify unusedArgument for criuScript.sh unused parameter $5 - the APP
ARGS;
Enable KEEP_TEST_OUTPUT for testMillisDelayBeforeCheckpointDone and
testMillisDelayAfterCheckpointDone.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9

JasonFengJ9 commented Apr 9, 2024

Copy link
Copy Markdown
Member Author

Rebased with #19277

@tajila

tajila commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity zlinux jdk17

@tajila

tajila commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

jenkins test sanity xlinux jdk17

@JasonFengJ9

JasonFengJ9 commented Apr 10, 2024

Copy link
Copy Markdown
Member Author

https://openj9-jenkins.osuosl.org/job/Test_openjdk17_j9_sanity.functional_x86-64_linux_Personal_testList_0/475/consoleFull

22:52:18 [OUT] pie: 5004: Error (criu/pie/restorer.c:1839): prctl failed @1839 with -1

A known failure

@tajila
tajila merged commit 73daf9b into eclipse-openj9:master Apr 10, 2024
@JasonFengJ9
JasonFengJ9 deleted the criutesttimeout branch April 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tajila tajila tajila approved these changes

Assignees

No one assigned

Labels

comp:test criu Used to track CRIU snapshot related work

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JasonFengJ9 @tajila @pshipton