CRIU Softmx Test Options - #19037
Merged
dmitripivkine merged 1 commit intoMar 12, 2024
Merged
Conversation
amicic
reviewed
Feb 28, 2024
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
2 times, most recently
from
February 29, 2024 12:07
cd934c1 to
37a1639
Compare
amicic
reviewed
Mar 4, 2024
amicic
reviewed
Mar 4, 2024
amicic
reviewed
Mar 5, 2024
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
from
March 5, 2024 16:26
4e2170e to
e80d8e4
Compare
amicic
reviewed
Mar 5, 2024
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
from
March 5, 2024 16:33
e80d8e4 to
202d6ff
Compare
kangyining
changed the title
amicic
reviewed
Mar 6, 2024
Contributor
|
list both options in the commit/PR comment |
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
from
March 6, 2024 16:04
9114935 to
8255f38
Compare
Contributor
|
@dmitripivkine please, have a look |
Contributor
There was a problem hiding this comment.
I think we should extend comment and explain what testContainerMemLimit is used for.
Contributor
There was a problem hiding this comment.
However, mentioning softmx is a bit too specific. I prefer more generic comment like "Also used in test farms to force container limits, where it's non-trivial to actually create/config containers for each test.
Contributor
|
looks ok, just a few minor suggestions |
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
from
March 6, 2024 17:20
8255f38 to
9bad246
Compare
amicic
approved these changes
Mar 6, 2024
Author
|
x86-64 Linux pass in Grinder: https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/38411/ wait for ppc and s390x grinder results Update: s390x works |
Functional changes for softmx testing. Add -XX:+fvtest_testContainerMemLimit and associated logics on checkpoint side to indicate if the current run is a test run. Add -XXgc:fvtest_testRAMSizePercentage and associated logics on restore side to mimic a different RAM setup. Signed off by: Frank.Kang@ibm.com
kangyining
force-pushed
the
softmx_fvtest_ramsizepercentage
branch
from
March 7, 2024 20:40
9bad246 to
608d09d
Compare
Contributor
|
Jenkins line endings check |
dmitripivkine
approved these changes
Mar 7, 2024
Contributor
|
Jenkins test sanity xLinux,aix jdk21 |
Contributor
|
Jenkins test sanity pLinux jdk11 |
kangyining
pushed a commit
to kangyining/openj9
that referenced
this pull request
Mar 12, 2024
Add supporting test cases and related testing scripts. Softmx functionalities: eclipse-openj9#18168 Functional changes: eclipse-openj9#19037
kangyining
pushed a commit
to kangyining/openj9
that referenced
this pull request
Mar 13, 2024
Add supporting test cases and related testing scripts. Softmx functionalities: eclipse-openj9#18168 Functional changes: eclipse-openj9#19037
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRIU Softmx Test Options
Functional changes for softmx testing.
Add -XX:+fvtest_testContainerMemLimit and associated logics
on checkpoint side to indicate if the current
run is a test run.
Add -XXgc:fvtest_testRAMSizePercentage and associated logics
on restore side to mimic a different RAM setup.
Signed off by: Frank.Kang@ibm.com