Skip to content

(0.41) AArch64 macOS: Stop assigning x18 - #18357

Merged
pshipton merged 1 commit into
eclipse-openj9:v0.41.0-releasefrom
knn-k:aarch64macos_x18_0.41
Oct 31, 2023
Merged

(0.41) AArch64 macOS: Stop assigning x18#18357
pshipton merged 1 commit into
eclipse-openj9:v0.41.0-releasefrom
knn-k:aarch64macos_x18_0.41

Conversation

@knn-k

@knn-k knn-k commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

This commit stops the JIT assigning the x18 register on AArch64 macOS.

Original PR in master: #18351

This commit stops the JIT assigning the x18 register on AArch64 macOS.

Original PR in master: eclipse-openj9#18351

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k

knn-k commented Oct 27, 2023

Copy link
Copy Markdown
Contributor Author

@0xdaryl 0xdaryl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes, but will defer to @pshipton if it can be contained in 0.41.

@pshipton

Copy link
Copy Markdown
Member

We can evaluate next week after going through some testing in the head stream.

@pshipton

pshipton commented Oct 28, 2023

Copy link
Copy Markdown
Member

Running some 0.41 testing, which is still going. So far there are a couple of DAA hangs in -Xjit:count=0 modes with user generated core files.

https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk11_j9_special.system_aarch64_mac_testList_1/288/

  • DaaLoadTest_all_special_5m_5

https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk11_j9_special.system_aarch64_mac_testList_4/65/

  • DaaLoadTest_daa1_special_5m_7

@pshipton

Copy link
Copy Markdown
Member

Also the following, but there are no diagnostic files.

https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk17_j9_special.system_aarch64_mac_testList_3/193/

  • DaaLoadTest_daa1_special_5m_24

@knn-k

knn-k commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

I ran Grinder jobs for DaaLoadTest_all_special_5m_5 and DaaLoadTest_daa1_special_5m_7, 20x each, and they finished successfully.
job/Grinder/35708/
job/Grinder/35709/

@knn-k

knn-k commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

Those failures with DaaLoadTest do not seem to relate to PR #18351.
See the following job on October 24, for example.
https://hyc-runtimes-jenkins.swg-devops.com/job/Test_openjdk11_j9_special.system_aarch64_mac/298/

@pshipton

Copy link
Copy Markdown
Member

@JasonFengJ9 do you see any concerns in the weekend internal testing of amac? Did we get testing on both jdk11 and 17?

@JasonFengJ9

Copy link
Copy Markdown
Member

do you see any concerns in the weekend internal testing of amac? Did we get testing on both jdk11 and 17?

From JDK 11/17/21 aarch64_mac weekly run containing #18351, there were a few java interrupted! (timed out?) and network-related infra issues, I don't see an issue that could have been caused by the PR in question.

@knn-k

knn-k commented Oct 31, 2023

Copy link
Copy Markdown
Contributor Author

See Issue #17090 for the timeouts with LoadTests on amac.

@pshipton

pshipton commented Oct 31, 2023

Copy link
Copy Markdown
Member

As the 0.41 and head stream testing looks good I will merge.

@pshipton
pshipton merged commit c8697e2 into eclipse-openj9:v0.41.0-release Oct 31, 2023
@knn-k
knn-k deleted the aarch64macos_x18_0.41 branch October 31, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants