[JDK21+] Increase wait time in VirtualThreadTests - #17928
Merged
pshipton merged 1 commit intoAug 10, 2023
Conversation
Contributor
Author
|
@pshipton @fengxue-IS Requesting your review. |
fengxue-IS
approved these changes
Aug 9, 2023
Contributor
Author
Yes, Java19andUp and Java20andUp versions are obsolete since we no longer support the associated Java versions. |
pshipton
reviewed
Aug 10, 2023
The wait time has been increased from 500 ms to 10000 ms. This should give the virtual thread sufficient time to park on slower machines. This impacts the following tests: - test_synchronizedBlockFromVirtualthread - test_jniFromVirtualthread test_YieldedVirtualThreadGetStackTrace was earlier updated in eclipse-openj9#17194. Fixes: eclipse-openj9#17924 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
add_incremental_delays_vthreadtests
branch
from
August 10, 2023 13:29
4c35324 to
d6c6a06
Compare
Member
|
Tested in grinder https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/2667/, which passed. |
pshipton
approved these changes
Aug 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wait time has been increased from 500 ms to 10000 ms. This should
give the virtual thread sufficient time to park on slower machines.
This impacts the following tests:
test_YieldedVirtualThreadGetStackTrace was earlier updated
in #17194.
Fixes: #17924
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com