Disable certain weight adjustments during early ECS - #17900
Merged
Conversation
Weight adjustments done during ECS based on arg count and whether args are load consts or boxed primitives can have a negative impact in certain workloads due to overly aggressive inlining. They are now guarded within environment variables. Signed-off-by: Nazim Bhuiyan <nubhuiyan@ibm.com>
nbhuiyan
changed the title
Member
Author
|
@vijaysun-omr / @0xdaryl requesting review. Guarding the problematic weight adjustments through environment variables addresses the regression seen in some workloads. |
Contributor
|
I'll defer to @0xdaryl on this since I will be away. |
Contributor
|
Jenkins test sanity all jdk11 |
Contributor
|
Jenkins test sanity aix,win jdk11 |
0xdaryl
approved these changes
Aug 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weight adjustments done during ECS based on arg count and whether args are load consts or boxed primitive can have a negative impact on certain workloads due to overly aggressive inlining. They are now guarded within environment variables.