Skip to content

Update OpenSSL to the 1.1.1 July 19 CVE level - #17828

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:opensslcvejuly19
Jul 21, 2023
Merged

Update OpenSSL to the 1.1.1 July 19 CVE level#17828
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:opensslcvejuly19

Conversation

@pshipton

Copy link
Copy Markdown
Member

Includes fix for CVE-2023-3446.

Includes fix for CVE-2023-3446.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
pshipton requested a review from keithc-ca July 20, 2023 14:12
pshipton added a commit to pshipton/openjdk-build that referenced this pull request Jul 20, 2023
Includes fix for CVE-2023-3446.

Port of eclipse-openj9/openj9#17828

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@AdamBrousseau

Copy link
Copy Markdown
Contributor

jenkins compile amac jdk11

@AdamBrousseau

Copy link
Copy Markdown
Contributor

I'm not convinced a tag is going to work instead of a branch because the clone uses the -b option instead of a clone followed by a checkout.
https://github.com/ibmruntimes/openj9-openjdk-jdk8/blob/8d52f27f414f9756e4c365786c249ec00757f2ff/closed/get_openssl_source.sh#L94C1-L94C56

git clone --depth=1 -b $OPENSSL_SOURCE_TAG $OPENSSL_URL

@pshipton

Copy link
Copy Markdown
Member Author

We always use a tag, there aren't branches for the releases. 1.1.1u is short form for a tag and is converted by get_openssl_source.sh to the tag name OpenSSL_1_1_1u.

The build looks correct, it contains output Configuring OpenSSL version 1.1.1v-dev

@pshipton

Copy link
Copy Markdown
Member Author

It also shows switching to '97b4f2b515ffd3ce91c6d5cd6d04614a4a15d7df' which is the correct SHA.

@keithc-ca

Copy link
Copy Markdown
Contributor

And

[2023-07-20T14:55:58.368Z] Compiling OpenJ9 in /Users/jenkins/workspace/Build_JDK11_aarch64_mac_Personal/build/macosx-aarch64-normal-server-release/vm
[2023-07-20T14:55:58.368Z]   Source version info:
[2023-07-20T14:55:58.368Z]     openjdk - 7ef5802f8c7
[2023-07-20T14:55:58.368Z]     openj9  - 2bfa51e0c09
[2023-07-20T14:55:58.368Z]     omr     - e6b8e7aa86b
[2023-07-20T14:55:58.368Z]     openssl - 97b4f2b5

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity.openjdk alinux64 jdk17

@pshipton

Copy link
Copy Markdown
Member Author

Since OpenSSL isn't bundled on alinux, sanity.openjdk testing isn't going to test the change. It would need to be run on Windows or Mac.

@keithc-ca

Copy link
Copy Markdown
Contributor

Jenkins test sanity.openjdk win jdk17

@pshipton

Copy link
Copy Markdown
Member Author

The failures are known issues unrelated to this change.

@keithc-ca

Copy link
Copy Markdown
Contributor

Test failures:

TEST: java/security/SecureRandom/ApiTest.java
TEST: java/security/SecureRandom/EnoughSeedTest.java

Those tests passed in a grinder: https://openj9-jenkins.osuosl.org/job/Grinder/2594/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants