Follow moved destObject in copyFlattenableArray - #17768
Merged
hangshao0 merged 1 commit intoJul 11, 2023
Merged
Conversation
When calling loadFlattenableArrayElement it is possible that destObject gets moved by the GC. We can get the new, correct address by pushing and popping destObject in a special frame. Fixes eclipse-openj9#17675 Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
Author
|
@hangshao0 |
hangshao0
self-requested a review
July 11, 2023 14:58
hangshao0
added
project:valhalla
Contributor
|
@theresa-m I added you as reviewer. |
Contributor
|
Jenkins test sanity,extended xlinuxval jdknext |
|
@ehrenjulzert Is there any way to contact you? |
Contributor
|
Hey @alexiskitten if you have any questions about this pr commenting here or on the OpenJ9 slack are the best places to reach the team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When calling loadFlattenableArrayElement it is possible that destObject gets moved by the GC. We can get the new, correct address by pushing and popping destObject in a special frame.
Fixes #17675