j9gc_createJavaLangString protects string objects across GC points - #17744
Merged
Conversation
Added PUSH_OBJECT_IN_SPECIAL_FRAME/POP_OBJECT_IN_SPECIAL_FRAME pairs. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
Member
|
This seems a low risk change we should add to the 0.40 release. |
tajila
approved these changes
Jul 6, 2023
Contributor
|
jenkins test sanity alinux64 jdk17 |
Member
Author
dmitripivkine
approved these changes
Jul 7, 2023
Contributor
|
@JasonFengJ9 Have you verified that every caller of the modified function has a special frame on stack? You can't use the push/pop macros without the right kind of frame. |
Contributor
|
Nevermind - I see the API is already making the assumption (using the macros). There still may be cases which are invalid, but this change makes nothing worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
j9gc_createJavaLangStringprotects string objects across GC pointsAdded
PUSH_OBJECT_IN_SPECIAL_FRAME/POP_OBJECT_IN_SPECIAL_FRAMEpairs.closes #17738
FYI @dmitripivkine
Signed-off-by: Jason Feng fengj@ca.ibm.com