Change API used for computing code cache size in low memory environments - #17666
Merged
Conversation
Contributor
Author
|
jenkins compile all jdk17 |
Contributor
Author
|
@dsouzai Could you please review/merge this commit? Thanks |
Contributor
Author
|
jenkins test sanity all jdk17 |
dsouzai
approved these changes
Jun 26, 2023
dsouzai
reviewed
Jun 26, 2023
Contributor
There was a problem hiding this comment.
Formatting issue, but I don't want to have to re-trigger all the tests, so maybe just update the code once everything passes.
Member
There was a problem hiding this comment.
Regardless of changes being pushed, you can find the PR build at https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/4003/, which will keep running.
Contributor
Author
There was a problem hiding this comment.
Indentation is fixed now
Contributor
Author
|
All tests have passed. i will fix the indentation and just verify it compiles. |
PR eclipse-openj9#17425 introduced a change for limiting the total size of the Code Cache to no more than 25% of available physical memory. This is done based on the output from the `computeAndCacheFreePhysicalMemory()` function. This function takes into consideration the amount of physical memory installed on the machine and the limits imposed by cgroups, but also looks at how much free physical memory is available (not used by other proceses) at the moment of the call. Thus, if there is a transient and very narrow spike of memory usage by some other process when our JVM starts, the JVM may think that it has very limitted physical memory and allocate a very small code cache repository. This commit changes the function used for computing physical memory to `omrsysinfo_get_addressable_physical_memory()` which looks at how much physical memory the JVM is allowed to use, rather than at how much physical memory is available. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
Contributor
Author
|
jenkins compile all jdk17 |
Contributor
Author
|
PR is ready to be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #17425 introduced a change for limiting the total size of the Code Cache to no more than 25% of available physical memory. This is done based on the output from the
computeAndCacheFreePhysicalMemory()function. This function takes into consideration the amount of physical memory installed on the machine and the limits imposed by cgroups, but also looks at how much free physical memory is available (not used by other proceses) at the moment of the call. Thus, if there is a transient and very narrow spike of memory usage by some other process when our JVM starts, the JVM may think that it has very limitted physical memory and allocate a very small code cache repository.This commit changes the function used for computing physical memory to
omrsysinfo_get_addressable_physical_memory()which looks at how much physical memory the JVM is allowed to use, rather than at how much physical memory is available.