Update the FFI specific code in JDK21 for JEP442 - #17597
Conversation
|
Note: |
2155993 to
784e7f5
Compare
|
Reviewer: @tajila |
|
I will need to double-check the code here to see whether it still works with the new changes in JDK21 at ibmruntimes/openj9-openjdk-jdk21#4 (just merged). |
|
Probably need to wait till the changes at ibmruntimes/openj9-openjdk-jdk21#4 is merged to the |
784e7f5 to
1dbcb97
Compare
|
As talked to Jason offline, the follow changes in OpenJDK should be merged altogether at first to get code related compiled correctly in JDK21/next: |
1dbcb97 to
a9d78db
Compare
|
There are a bunch of test failures with padding/alignment detected in OpenJ9 FFI test suites with the newly merged changes (with check on the padding/alignment) in JDK21. I will need to check case by case to see whether it is simply a test issue or anything related to our code that needs to be addressed. |
8c21068 to
ecdc2c5
Compare
|
I've went through all failing test cases which was caused by https://github.com/ibmruntimes/openj9-openjdk-jdk21/blob/0a869c9c5496e25f7f89805471071640a4457d68/src/java.base/share/classes/jdk/internal/foreign/abi/AbstractLinker.java#L222C1-L229C6 which the alignment/padding related code has been adjusted in OpenJDK in which case the trailing padding is no longer required in struct except a few cases on AIX (e.g. |
|
The PR has been verified on all supported platforms (no code required in OpenJDK) with the updated test cases and is ready for review. |
ecdc2c5 to
43d2e73
Compare
43d2e73 to
f1cdebf
Compare
|
@tajila, any more comment for this PR? |
|
jenkins sanity test xlinux,plinux jdk21 |
|
jenkins test sanity xlinux,plinux jdk21 |
|
The test failures at https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_x86-64_linux_Personal/2/tapTestReport/ & https://openj9-jenkins.osuosl.org/job/Test_openjdk21_j9_sanity.functional_ppc64le_linux_Personal/2/tapTestReport/ are related to |
The modifications are based on the latest APIs in JDK21 to support JEP442 as mentioned at eclipse-openj9#16951. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
f1cdebf to
4134c7f
Compare
|
jenkins test sanity xlinux,plinux jdk21 |
The modifications are based on the latest APIs in JDK21
to support JEP442 as mentioned at #16951.
Signed-off-by: ChengJin01 jincheng@ca.ibm.com