Check flattenable value types and if Q signature is supported - #17447
Merged
hzongaro merged 2 commits intoJun 7, 2023
Conversation
a7ehuo
commented
May 23, 2023
Contributor
Author
|
@hzongaro May I ask you to review this change? Thank you!
|
Contributor
Author
|
Just a heads up. I found a few more places in the following files that require the checking on if Q signature is supported or not. However, any change in the current commit b39fe6e is still good for review |
a7ehuo
commented
May 23, 2023
a7ehuo
force-pushed
the
separate-nullRestricted-remove-q-2
branch
from
May 24, 2023 16:41
b39fe6e to
857d60f
Compare
a7ehuo
changed the title
hzongaro
reviewed
May 29, 2023
hzongaro
left a comment
hzongaro
left a comment
Member
There was a problem hiding this comment.
Just a few minor comments, possibly for discussion
a7ehuo
added
comp:jit
project:valhalla
- `areFlattenableValueTypesEnabled`: Whether or not flattenable value object (aka null restricted) type is enabled - `isQDescriptorForValueTypesSupported`: Whether or not `Q` signature is supported - Update `isValueTypeArrayFlatteningEnabled` to check `areFlattenableValueTypesEnabled` first Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
separate-nullRestricted-remove-q-2
branch
from
June 5, 2023 12:48
857d60f to
c4346cc
Compare
Contributor
Author
|
@hzongaro all comments are addressed. Ready for another review. Thanks! |
hzongaro
reviewed
Jun 5, 2023
- Check `areFlattenableValueTypesEnabled` before checking if element is flattened - Check if Q signature is supported or not before using Q signature to determine if the element is a value type. - Remove special handling on checking primitive value type in `genCheckcast` and disable `testCheckCastValueTypeOnNull` since the latest spec doesn't require special handling on null restricted value types. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
separate-nullRestricted-remove-q-2
branch
from
June 6, 2023 01:59
c4346cc to
156b344
Compare
Contributor
Author
|
@hzongaro all comments are addressed. Ready for another review. Thanks! |
Member
|
Jenkins test sanity all jdk11,jdk17 |
Member
|
Jenkins test sanity,extended xlinuxval jdknext |
Contributor
Author
|
|
Member
|
Jenkins test sanity osx jdk17 |
Member
|
Testing has passed, and review was completed. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
areFlattenableValueTypesEnabledbefore checking if element is flattenedQsignature is supported or not before usingQsignature to determine if the element is a value typeQsignature is supported andQsignature is not supported. This change does not handle the case whereQsignature is not supported. At the moment as long as flattenable value types are enabled,Qsignature is still supportedgenCheckcastand disabletestCheckCastValueTypeOnNullsince the latest spec doesn't require special handling on null restricted value types.