Check if instanceDescription is an immediate value in loop - #15713
Merged
hzongaro merged 1 commit intoAug 19, 2022
Merged
Conversation
a7ehuo
force-pushed
the
fix-TR_VMFieldsInfo-instanceDescription
branch
from
August 15, 2022 20:16
8bc5405 to
67035db
Compare
There is a case where the number of object slots are greater than the number of bits in a word and `instanceDescription` is used as an immediate value instead of a pointer, such as when the class doesn't have any references. We need to break the loop in this case before `instanceDescription` is dereferenced as a pointer. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
fix-TR_VMFieldsInfo-instanceDescription
branch
from
August 16, 2022 13:46
67035db to
c80610b
Compare
a7ehuo
changed the title
Member
Member
|
Brad @BradleyWood, may I ask you to review this pull request as well? |
a7ehuo
changed the title
tajila
approved these changes
Aug 18, 2022
Member
|
LGTM |
Member
|
Jenkins test sanity,extended xlinuxval jdknext |
Member
|
Jenkins test sanity all jdk17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a case where the number of object slots are greater than the number of bits in a word and
instanceDescriptionis used as an immediate value instead of a pointer, such as when the class doesn't have any references. We need to break the loop in this case beforeinstanceDescriptionis dereferenced as a pointer.This fixes
openj9-jit-xopt/issues/529Thanks to Henry @hzongaro for tracking down the issue to hasReferneces change #10651
Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com