Check for vector support on Z in supportedForPlatform - #15711
Merged
Conversation
Contributor
Author
|
@gita-omr Can I please get your review on this? |
gita-omr
reviewed
Aug 16, 2022
Contributor
There was a problem hiding this comment.
Maybe split it into 3 lines, one per platform?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Had a typo in last push, fixed it in https://github.com/eclipse-openj9/openj9/compare/cb468f4114cd748f7749011a4d476ad5023a4b1a..7ea3491e40e4dd1647e00312e1140b330dc66ff2
While generating the vector opcodes for loading and storing in vector api expansion, we need to check if the vector supports is available on Z. This commit adds that check in to supportedOnPlatform query. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
gita-omr
approved these changes
Aug 16, 2022
Contributor
|
jenkins test sanity all jdk8,jdk19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While generating the vector opcodes for loading and storing in vector
api expansion, we need to check if the vector supports is available on
Z. This commit adds that check in to supportedOnPlatform query.
Signed-off-by: Rahil Shah rahil@ca.ibm.com