Remove setting of Vector Supports in Linkage - #15546
Merged
Merged
Conversation
r30shah
changed the title
Previously support of vector registers were checked while creating a private linkage, which would not be a good place to do so. It should be set while initializing Code Generator Object. This PR removes that part of code from OpenJ9. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
r30shah
force-pushed
the
removeVectorSupportCheck
branch
from
July 18, 2022 20:09
b957b93 to
3e43147
Compare
r30shah
changed the title
Contributor
Author
|
@joransiu Once we get changes in eclipse-omr/omr#6606 merged, we can clean-up the code that sets up things in Linkage through this PR. Can I please get your review on this one? Build ids I posted in eclipse-omr/omr#6606 (comment) tests out this changes as well. |
joransiu
approved these changes
Jul 21, 2022
Member
|
jenkins test sanity zlinux jdk11,jdk17 depends eclipse-omr/omr#6606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously support of vector registers were checked while creating a
private linkage, which would not be a good place to do so. It should be
set while initializing Code Generator Object. This PR removes that part
of code from OpenJ9.
Signed-off-by: Rahil Shah rahil@ca.ibm.com