Deadlock prevention on @NotCheckpointSafe frames - #15540
Merged
Merged
Conversation
tajila
force-pushed
the
criu2
branch
2 times, most recently
from
July 13, 2022 19:39
b913b55 to
900fff1
Compare
Contributor
Author
|
@gacholio Please take a look at these changes |
Contributor
Author
|
Jenkins test sanity xlinuxcriu jdk11 |
Contributor
|
You should probably update the DDR rom dumper with the new bit. |
JasonFengJ9
reviewed
Jul 14, 2022
Contributor
Author
I couldnt find an example of this for other annotations like |
Contributor
|
It's entirely possible that they were missed too. I believe the DDR dumper is used far far more than cfdump these days, so that's where we really need the proper decode. |
gacholio
reviewed
Jul 18, 2022
gacholio
reviewed
Jul 18, 2022
Contributor
Author
I created a new PR to address that, #15561 |
tajila
force-pushed
the
criu2
branch
2 times, most recently
from
July 19, 2022 17:14
ae7d0a6 to
f2246d1
Compare
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
reviewed
Jul 19, 2022
gacholio
approved these changes
Jul 19, 2022
Contributor
|
You can launch appropriate testing. |
Contributor
Author
|
Jenkins test sanity win jdk8 |
Contributor
Author
|
Jenkins test sanity xlinuxcriu jdk11 |
Contributor
|
gacholio
reviewed
Jul 19, 2022
Contributor
Author
|
Jenkins test sanity win jdk8 |
Contributor
Author
|
link to the xlinux build https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJ9/2439/ |
gacholio
reviewed
Jul 19, 2022
There are certain operations in the JCL that acquire a global lock (ie. methodType interning). The PR introduces a new mechanism to delay taking a checkpoint (for a certain amount of attempts) while a non checkpoint thread owns the global resource. Fixes: eclipse-openj9#15367 Signed-off-by: Tobi Ajila <atobia@ca.ibm.com>
Contributor
Author
|
Jenkins test sanity win jdk8 |
Contributor
Author
|
The xlinux build passed as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deadlock prevention on @NotCheckpointSafe frames
There are certain operations in the JCL that acquire a global lock (ie.
methodType interning). The PR introduces a new mechanism to delay taking
a checkpoint (for a certain amount of attempts) while a non checkpoint
thread owns the global resource.
Fixes: #15367
Signed-off-by: Tobi Ajila atobia@ca.ibm.com