Skip to content

Do not set backfillOffset of VT to -1 - #15497

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:hashcode
Jul 12, 2022
Merged

Do not set backfillOffset of VT to -1#15497
tajila merged 1 commit into
eclipse-openj9:masterfrom
hangshao0:hashcode

Conversation

@hangshao0

Copy link
Copy Markdown
Contributor
  1. Set backfillOffset of VT to instance size as normal classes.
  2. Copy the VT hash code when doing copyObjectFields().

Signed-off-by: Hang Shao hangshao@ca.ibm.com

1. Set backfillOffset of VT to instance size as normal classes.
2. Copy the VT hash code when doing copyObjectFields().

Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:vm comp:gc labels Jul 6, 2022
@hangshao0

Copy link
Copy Markdown
Contributor Author

This change prevents the crash in GC to unblock performance testing for the JIT team.

We still need to calculate the hashcode of value type based on the value rather than the identity, which can be done through a separate PR.

@hangshao0
hangshao0 requested review from dmitripivkine and tajila July 6, 2022 20:28
@tajila

tajila commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity,extended plinuxval jdknext

@tajila

tajila commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity win jdk8

@tajila

tajila commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity xlinuxvalst jdknext

@hangshao0

Copy link
Copy Markdown
Contributor Author

The hang in the PR build should be fixed by #15528

@tajila
tajila merged commit bb9bbff into eclipse-openj9:master Jul 12, 2022
@hangshao0
hangshao0 deleted the hashcode branch September 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:gc comp:vm project:valhalla Used to track Project Valhalla related work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants