Fix zeroReg initialization when disableBatchClear is set - #15371
Merged
Conversation
Contributor
Author
ymanton
reviewed
Jun 20, 2022
bhavanisn
force-pushed
the
disBatchClr_fix
branch
from
June 21, 2022 18:45
91017c2 to
8a701da
Compare
ymanton
reviewed
Jun 23, 2022
Member
|
Jenkins test sanity.functional plinux,aix jdk8,jdk11 |
Member
|
Batch clearing is disabled by default so PR tests are verifying that the patches don't break the default behaviour. I've checked with @bhavanisn that internal testing to verify that running with batch clearing actually disabled also passes testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the incorrect flag check for zeroReg initialization in case
TR_DisableBatchClear option is enabled. In spite of dualTLH is enabled
or not when DisableBatchClear option is enabled, the heap allocated
has to be zeroInitialized by jitted code else will lead to crash due to
random memory values as GC will skip zero Initialization.