Add initial VM structure and JCL stub for Continuation - #15293
Conversation
There was a problem hiding this comment.
Is this to be processed by Javadoc tool to generate the API docs, or just a comment? In later case, /* */ is sufficient, similar comments for other occurrences.
There was a problem hiding this comment.
The /** */ syntax is generated by the IDE when I auto corrected the format, not sure if Javadoc is need for this class as it should internal.
I have removed most of the docs that are redundant
There was a problem hiding this comment.
Since GC will fully maintain Continuation Lists(list of Continuation Objects instead of J9VMContinuation), we don't need to linkNext and linkPrevious in J9VMContinuation(there would hidden field continuationLink in Continuation Oject for the list) and also it is hard to maintain linkNext and linkPrevious from GC, we can provide an iterator for retrieving the list of J9VMContinuation.
There was a problem hiding this comment.
but GC will not maintain(set and update) both linkNext and linkPrevious during collections.
There was a problem hiding this comment.
GC will call a vmHook for that
e047731 to
118831b
Compare
|
@LinHu2016 After discussing with Jack, we will omit the linkedlist changes for this PR. Feel free to us a hiddenfield to add the |
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com>
|
Jenkins sanity amac jdknext |
|
Jenkins compile win jdknext |
| vm->cifArgumentTypesCacheMutex = NULL; | ||
| } | ||
| #endif /* JAVA_SPEC_VERSION >= 16 */ | ||
|
|
There was a problem hiding this comment.
just noticed this. @fengxue-IS can you make a PR to remove the added whitespace
4 participants
Related: #15172
Signed-off-by: Jack Lu Jack.S.Lu@ibm.com