Deprecate -XX:+AllowNonVirtualCalls - #15234
Merged
Merged
Conversation
Member
Author
|
I've got the deprecation release note pointing to this PR. If there is a better issue to use pls let me know. |
keithc-ca
requested changes
Jun 6, 2022
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
Why doesn't this also include the code changes to issue that warning (or error) for Java 20+?
Member
Author
|
Updated. |
Member
Author
|
Made another update to replace "Java" with "OpenJDK". Also in older release notes. |
Contributor
|
When I spoke of code changes, I suppose I was expecting that jvminit.c#L3549 would change from to (and the matching |
Member
Author
|
Yes, I originally missed that comment but was just starting to look at it. I was assuming that would be done separately, but no reason I can't add it to this PR. |
Member
Author
|
Updated now. |
keithc-ca
reviewed
Jun 6, 2022
Also replace "Java" with "OpenJDK" in recent release notes to match the convention. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
Member
Author
|
Updated. |
keithc-ca
approved these changes
Jun 6, 2022
Contributor
|
jenkins compile amac jdk17 |
tajila
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also replace "Java" with "OpenJDK" in recent release notes to match the convention.