Skip to content

Remove duplicate typedef in tests downcall.h - #15133

Merged
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:dupstruct
May 27, 2022
Merged

Remove duplicate typedef in tests downcall.h#15133
keithc-ca merged 1 commit into
eclipse-openj9:masterfrom
pshipton:dupstruct

Conversation

@pshipton

@pshipton pshipton commented May 27, 2022

Copy link
Copy Markdown
Member

The following dup is removed:
typedef struct stru_Byte_Byte_Byte stru_Byte_Byte_Byte;

It fails to compile on the latest xlC 16.1.0.7 on AIX.

@pshipton
Remove duplicate typedef in tests downcall.h
0600196 
The following dup is removed:
typedef struct stru_Byte_Byte_Byte stru_Byte_Byte_Byte;

It fails to compile on the latest xlC 16.1.0.7 on AIX.

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton

pshipton commented May 27, 2022

Copy link
Copy Markdown
Member Author

@ChengJin01 fyi

@pshipton
pshipton requested a review from keithc-ca May 27, 2022 18:01
@pshipton

pshipton commented May 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

fyi testing is done internally at /view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/13060/
Without this change the build failed to compile.
Related to updating the xlC version runtimes/infrastructure/issues/6768#issuecomment-44319561

18:00:44  /home/jenkins/workspace/Build_JDK11_ppc64_aix_Personal/openj9/runtime/tests/clinkerffi/downcall.h:54:36: error: redefinition of typedef 'stru_Byte_Byte_Byte' is a C11 feature [-Werror,-Wtypedef-redefinition]
18:00:44  typedef struct stru_Byte_Byte_Byte stru_Byte_Byte_Byte;
18:00:44                                     ^
18:00:44  /home/jenkins/workspace/Build_JDK11_ppc64_aix_Personal/openj9/runtime/tests/clinkerffi/downcall.h:47:36: note: previous definition is here
18:00:44  typedef struct stru_Byte_Byte_Byte stru_Byte_Byte_Byte;
18:00:44                                     ^
18:00:44  1 error generated.
18:00:44  Error while processing /home/jenkins/workspace/Build_JDK11_ppc64_aix_Personal/openj9/runtime/tests/clinkerffi/downcall.c.

keithc-ca
keithc-ca reviewed May 27, 2022
View reviewed changes
Comment thread runtime/tests/clinkerffi/downcall.h
@keithc-ca keithc-ca mentioned this pull request May 27, 2022
Closed
@keithc-ca

keithc-ca commented May 27, 2022

Copy link
Copy Markdown
Contributor

Tested change locally as well.

@keithc-ca
keithc-ca merged commit 92d45ee into eclipse-openj9:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees

No one assigned

Labels

comp:test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pshipton @keithc-ca