Avoid GREATER_EQUAL in CMake files - #15113
Merged
Merged
Conversation
keithc-ca
reviewed
May 25, 2022
GREATER_EQUAL is not available in the minimum CMake version that OpenJ9 supports. So, Java version >= 11 is rewritten as an "else()". Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
ojdk_mhs_jdk8_v1
branch
from
May 25, 2022 15:56
492b1df to
c1572f3
Compare
Contributor
|
jenkins compile x86-64_windows_ojdk292 jdknext |
Contributor
|
jenkins compile x86-64_windows_ojdk292 jdk8,jdk11 |
Contributor
|
jenkins compile x86-64_windows_ojdk292 jdk17 |
Contributor
|
jenkins compile win jdk17 |
Contributor
|
Contributor
|
An example failure without this can be found in https://openj9-jenkins.osuosl.org/job/Build_JDK11_x86-64_windows_ojdk292_Personal/3: |
keithc-ca
approved these changes
May 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GREATER_EQUAL is not available in the minimum CMake version that OpenJ9
supports.
So, Java version >= 11 is rewritten as an "else()".
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com