Skip to content

Disable the FFI specific test suites in Java 19 - #15089

Merged
tajila merged 1 commit into
eclipse-openj9:masterfrom
ChengJin01:disable_ffi_downcall_tests_jdk19
May 30, 2022
Merged

Disable the FFI specific test suites in Java 19#15089
tajila merged 1 commit into
eclipse-openj9:masterfrom
ChengJin01:disable_ffi_downcall_tests_jdk19

Conversation

@ChengJin01

Copy link
Copy Markdown

The change is to only enable the FFI specific test suites
on Java 18 given there is on backward compatibility between
Java 19 and Java 18 in terms of FFI APIs.

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

@ChengJin01
ChengJin01 force-pushed the disable_ffi_downcall_tests_jdk19 branch from aea2f12 to 472c331 Compare May 19, 2022 04:40
@ChengJin01

ChengJin01 commented May 19, 2022

Copy link
Copy Markdown
Author

The test suites intended for Java 18 become invalid once ibmruntimes/openj9-openjdk-jdk#443 (new APs in Java 19) gets merged to the repo, in which case we will need to move all test suites with all updated APIs to Java19andUp.

@ChengJin01

Copy link
Copy Markdown
Author

Reviewer: @tajila
FYI: @pshipton

@ChengJin01
ChengJin01 requested a review from tajila May 19, 2022 15:11
@ChengJin01

Copy link
Copy Markdown
Author

Note: this PR must be merged before the code at #15091 to avoid running tests in builds.

@tajila

tajila commented May 26, 2022

Copy link
Copy Markdown
Contributor

Jenkins test sanity plinux jdk18,jdk17

@ChengJin01

Copy link
Copy Markdown
Author

It seems the test cases will be compiled in Java 19 (reminded by Jack when compiling with openj9-staging), which means somewhere in build.xml needs to be updated accordingly to prevent them from being compiling. Will double-check again to see how to deal with this.

@ChengJin01
ChengJin01 force-pushed the disable_ffi_downcall_tests_jdk19 branch 2 times, most recently from 708e28e to a4c93ce Compare May 26, 2022 20:50
@ChengJin01

ChengJin01 commented May 26, 2022

Copy link
Copy Markdown
Author

I just updated all build.xml in Java16andUp, Java17andUp and Java18andUp to ensure the FFI specific test cases are only compiled with the correct JDK version given there is no backward compatibility with each other. Meanwhile, the test in foreignMemoryAccess is restricted to Java16/17/18 as the scope specific APIs are replaced with the MemorySession specific APIs in Java 19, which are moved to java.base.

@ChengJin01

ChengJin01 commented May 26, 2022

Copy link
Copy Markdown
Author

@llxia, please take a look at the test setting/framework in Java 16, 17 and 18 (including build.xml and playlist.xml, etc) to see whether it works this way as expected.

@ChengJin01
ChengJin01 requested a review from llxia May 26, 2022 20:56

@llxia llxia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia

llxia commented May 27, 2022

Copy link
Copy Markdown
Contributor

jenkins test sanity,extended xlinux jdknext,jdk11,jdk17

@ChengJin01
ChengJin01 force-pushed the disable_ffi_downcall_tests_jdk19 branch from a4c93ce to 7bb2c14 Compare May 30, 2022 15:05
The change is to only enable the FFI specific test suites
on Java 18 given there is on backward compatibility between
Java 19 and Java 18 in terms of FFI APIs.

Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
@ChengJin01
ChengJin01 force-pushed the disable_ffi_downcall_tests_jdk19 branch from 7bb2c14 to f8b4312 Compare May 30, 2022 15:15
@ChengJin01

Copy link
Copy Markdown
Author

I've updated the build.xml to adding the missing setting for the TestUtilities directory and verified locally to pass the compilation in Java 17 & 18. I'm not aware that the changes have anything to do with Java 11.

@llxia, please run jenkins again to see whether everything works fine with the update.

@llxia

llxia commented May 30, 2022

Copy link
Copy Markdown
Contributor

jenkins test sanity,extended xlinux jdknext,jdk11,jdk17

@tajila
tajila merged commit fda5fb3 into eclipse-openj9:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants