Guarantee new array will be zero initialized in transformArrayCloneCall (0.48) - #213
Merged
hzongaro merged 1 commit intoOct 7, 2024
Merged
Conversation
Guarantee that new array generated from transformation of array clone call will always be zero initialized, ensuring array allocation is done inline, whether TR_disableSkipZeroInitInVP is enabled or not Signed-off-by: Dylan Tuttle <jdylantuttle@gmail.com>
Contributor
Author
Member
|
What does this fix pls? |
Contributor
Author
|
It fixes a performance deficit relative to HotSpot when cloning arrays. We have a bug that causes allocation of a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guarantee that
newarrays generated from transformations of array clone calls will always be zero initialized, ensuring array allocation is done inline, whetherTR_disableSkipZeroInitInVPis enabled or not.While investigation and development into a fix for a bug caused by corruption of a TLH pointer forcing out of line array allocation when we skip zero initialization is ongoing, this PR will provide a temporary performance boost at the (rare and minor) expense of occasional zero initialization of arrays that don't need to be zero initialized.
This PR ports omr #7481 to the 0.48 release.