Skip to content

(0.46) x86-64: Use rep movs instructions if array copy size greater than 32 bytes - #209

Merged
vijaysun-omr merged 1 commit into
eclipse-openj9:v0.46.0-releasefrom
a7ehuo:system-arraycopy-perf-13-byte-char-threshold-32bytes-v46
Jun 20, 2024
Merged

(0.46) x86-64: Use rep movs instructions if array copy size greater than 32 bytes#209
vijaysun-omr merged 1 commit into
eclipse-openj9:v0.46.0-releasefrom
a7ehuo:system-arraycopy-perf-13-byte-char-threshold-32bytes-v46

Conversation

@a7ehuo

@a7ehuo a7ehuo commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

This PR ports eclipse-omr/omr#7384 to v0.46


This change applies to byte and char array System.arraycopy sequence. It avoids using vector instructions for copy size between 32 bytes to 64 bytes due to an observed regression.

â€Ķbytes

This change applies to byte and char array System.arraycopy
sequence. It avoids using vector instructions for copy
size between 32 bytes to 64 bytes due to an observed regression.

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo
a7ehuo marked this pull request as ready for review June 18, 2024 17:27
@a7ehuo
a7ehuo requested review from 0xdaryl and mstoodle as code owners June 18, 2024 17:27
@a7ehuo
a7ehuo removed the request for review from mstoodle June 18, 2024 17:27
@a7ehuo

a7ehuo commented Jun 18, 2024

Copy link
Copy Markdown
Contributor Author

@0xdaryl

0xdaryl commented Jun 18, 2024

Copy link
Copy Markdown
Contributor

This needs to wait until eclipse-omr/omr#7384 promotes and passes OMR acceptance.

@pshipton : for awareness and concerns

@a7ehuo

a7ehuo commented Jun 19, 2024

Copy link
Copy Markdown
Contributor Author

There are some failures from the OMR acceptance build: https://openj9-jenkins.osuosl.org/job/Pipeline-OMR-Acceptance/707/, which look to me are known issues

aarch64_linux jdk 11 sanity.openjdk: jdk_security4_0_failed

ppc64_aix jdk 17 sanity.openjdk: jdk_lang_VarHandleTest_j9_1_FAILED, jdk_lang_VarHandleTest_j9_0_FAILED

s390x_linux jdk 17 sanity.openjdk: jdk_lang_VarHandleTest_j9_0_FAILED, jdk_lang_VarHandleTest_j9_1_FAILED

@pshipton

Copy link
Copy Markdown
Member

I already promoted the OMR acceptance build earlier today.

@vijaysun-omr
vijaysun-omr merged commit 372b65b into eclipse-openj9:v0.46.0-release Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants