Remove unused fields from OMR_VMThread - #8109
Merged
Merged
Conversation
Contributor
Author
|
Related openj9 PR eclipse-openj9/openj9#23280 |
shadman2606
force-pushed
the
removefields_0129
branch
from
January 29, 2026 18:43
bb44d49 to
9d15ae9
Compare
shadman2606
changed the title
shadman2606
marked this pull request as ready for review
January 29, 2026 18:58
| walkThread->heapSizeForBarrierRange0 = heapSizeForBarrierRange0; | ||
| } | ||
| } | ||
| virtual void setTenureAddressRange(void* base, uintptr_t size) {} |
Contributor
There was a problem hiding this comment.
I think code formatting close to Coding Standards is:
virtual void
setTenureAddressRange(void* base, uintptr_t size)
{
}
Contributor
There was a problem hiding this comment.
Hm, or is it?
- declarations line
- function name/parameters
- opening {
- empty line
- closing }
Contributor
Author
There was a problem hiding this comment.
Sorry, just fixed it again. Code editor was undoing some of my formatting before I hit save 😞
shadman2606
force-pushed
the
removefields_0129
branch
3 times, most recently
from
January 29, 2026 19:55
131d69b to
d32629a
Compare
shadman2606
changed the title
dmitripivkine
approved these changes
Jan 30, 2026
Contributor
|
@babsingh Would you please help to merge? |
Contributor
|
jenkins build all |
Contributor
|
not sure, but _tenureBase/Size might still need to be set |
Removes the following fields from OMR_VMThread: - lowTenureAddress - highTenureAddress; - heapBaseForBarrierRange0; - heapSizeForBarrierRange0 This reverts changes from a previous (unfinished) work to trasfer these fields from J9VMThread to OMR_VMThread. Signed-off-by: Shadman Siddiqui shadman2606@gmail.com
shadman2606
force-pushed
the
removefields_0129
branch
from
January 30, 2026 21:21
e6f3854 to
2e858ef
Compare
Contributor
|
jenkins build all |
Contributor
|
PR builds look good. Only known and unrelated failures are present. |
babsingh
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unused fields from OMR_VMThread
Removes the following fields from OMR_VMThread:
This reverts changes from a previous (unfinished) work to transfer these fields from J9VMThread to OMR_VMThread.
Signed-off-by: Shadman Siddiqui shadman2606@gmail.com