Skip to content

Tidy up thread API - #8064

Merged
dsouzai merged 2 commits into
eclipse-omr:masterfrom
babsingh:omrthread_global
Dec 3, 2025
Merged

Tidy up thread API#8064
dsouzai merged 2 commits into
eclipse-omr:masterfrom
babsingh:omrthread_global

Conversation

@babsingh

@babsingh babsingh commented Dec 2, 2025

Copy link
Copy Markdown
Contributor
  • don't require a non-const name
  • remove useless const qualifier
  • remove (now) unnecessary casts
  • fix comments
  • improve adherence to coding standard

keithc-ca and others added 2 commits December 2, 2025 16:21
* don't require a non-const name
* remove useless const qualifier
* remove (now) unnecessary casts
* fix comments
* improve adherence to coding standard

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
@babsingh

babsingh commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

jenkins build all

@babsingh

babsingh commented Dec 2, 2025

Copy link
Copy Markdown
Contributor Author

@dsouzai, can you help merge this PR? It is a copy of #8057 with an additional fix for a Windows compilation failure. #8057 looks good to me; however, @keithc-ca is on vacation until Jan 26, and @pshipton requested that #8057 be merged. I opened this PR to include the Windows fix so it can move forward.

The pLinux failure is known and unrelated: #6571.

@babsingh
babsingh requested a review from dsouzai December 2, 2025 22:02
@babsingh babsingh mentioned this pull request Dec 2, 2025
@dsouzai dsouzai self-assigned this Dec 3, 2025
@dsouzai
dsouzai merged commit eb2e215 into eclipse-omr:master Dec 3, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants