Re-enable addKnownObjectConstraints() for JITServer - #8062
Merged
Conversation
dsouzai
requested changes
Dec 1, 2025
dsouzai
left a comment
dsouzai
left a comment
Contributor
There was a problem hiding this comment.
Looks fine to me; code formatting needs to be fixed.
The functionality of addKnownObjectConstraints() was disabled for JITServer due to the large number of messages it generates to retrieve information related to "known objects". This problem has been solved to a large extent in OpenJ9 through the addition of caching (see eclipse-openj9/openj9#23012). This commit re-enables addKnownObjectConstraints() for JITServer. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
Contributor
Author
|
Pushed change to address the formatting. |
dsouzai
approved these changes
Dec 1, 2025
Contributor
|
jenkins build all |
Contributor
Author
|
The failure on linux_ppc-64_le_gcc is similar to other failures that have happened in the recent past. |
mpirvu
added a commit
to mpirvu/openj9
that referenced
this pull request
Dec 4, 2025
OpenJ9 PR eclipse-openj9#23012 and omr PRs eclipse-omr/omr#8056 and eclipse-omr/omr#8062 implemented caching for the knownObjectTable. This PR performs the code cleanup removing unused data structures and functions. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
annaibm
pushed a commit
to annaibm/openj9
that referenced
this pull request
Mar 19, 2026
OpenJ9 PR eclipse-openj9#23012 and omr PRs eclipse-omr/omr#8056 and eclipse-omr/omr#8062 implemented caching for the knownObjectTable. This PR performs the code cleanup removing unused data structures and functions. Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality of addKnownObjectConstraints() was disabled for JITServer due to the large number of messages it generates to retrieve information related to "known objects". This problem has been solved to a large extent in OpenJ9 through the addition of caching (see eclipse-openj9/openj9#23012). This commit re-enables addKnownObjectConstraints() for JITServer.