Apply clang-format directives to prevent reformatting of diagrams - #8029
Merged
Conversation
hzongaro
requested review from
0xdaryl,
mstoodle and
vijaysun-omr
as code owners
November 5, 2025 18:23
Contributor
Author
|
@dsouzai, may I ask you to review this pull request? |
Contributor
|
Thanks for finding and fixing these @hzongaro . |
dsouzai
requested changes
Nov 5, 2025
dsouzai
left a comment
dsouzai
left a comment
Contributor
There was a problem hiding this comment.
There's a couple of minor errors, but overall LGTM
Diagrams sometimes appear in code comments to illustrate fragments of IL trees, control flow graphs or memory layout. Restore some instances that had been reformatted by clang format, and use the clang-format directive to prevent any future reformatting of those instances. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
hzongaro
force-pushed
the
fix-up-tree-art
branch
from
November 5, 2025 20:35
e02fd48 to
2aa6ef3
Compare
dsouzai
approved these changes
Nov 5, 2025
Contributor
|
jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagrams sometimes appear in code comments to illustrate fragments of IL trees, control flow graphs or memory layout. Restore some instances that had been reformatted by clang format, and use the clang-format directive to prevent any future reformatting of those instances.