Add OMR_ISSPACE macro for Open XL - #8017
Merged
Merged
Conversation
Contributor
|
@keithc-ca : please review |
keithc-ca
suggested changes
Nov 4, 2025
keithc-ca
left a comment
keithc-ca
left a comment
Contributor
There was a problem hiding this comment.
There are other uses of isspace() that should, perhaps, be changed to use OMR_ISSPACE(). I can't think of reasons for isspace to occur anywhere in this repository other than in omrcomp.h. As I searched, I also found uses of isdigit() that probably should have been replaced by OMR_ISDIGIT().
Deigue
added a commit
to Deigue/openj9
that referenced
this pull request
Nov 10, 2025
OMR_ISSPACE is a macro that provides a more flexible implementation to find spaces for a given parameter. It will conditionally use the BIMODAL function `__isspace_a()` when the ASCII version of the function is required on z/OS. This depends on: eclipse-omr/omr#8017 Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
Deigue
force-pushed
the
omr-isspace
branch
2 times, most recently
from
November 10, 2025 16:56
6e917ac to
56dbe0a
Compare
Deigue
marked this pull request as draft
November 10, 2025 20:17
Replaces usage of isspace() with OMR_ISSPACE() This conditionally uses __isspace_a() on z/OS platforms, to properly handle ASCII input. Also updates some isdigit() references to OMR_ISDIGIT() Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
keithc-ca
approved these changes
Nov 12, 2025
Deigue
added a commit
to Deigue/openj9
that referenced
this pull request
Nov 14, 2025
OMR_ISSPACE is a macro that provides a more flexible implementation to find spaces for a given parameter. It will conditionally use the BIMODAL function `__isspace_a()` when the ASCII version of the function is required on z/OS. This depends on: eclipse-omr/omr#8017 Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
Deigue
added a commit
to Deigue/openj9
that referenced
this pull request
Nov 14, 2025
OMR_ISSPACE is a macro that provides a more flexible implementation to find spaces for a given parameter. It will conditionally use the BIMODAL function `__isspace_a()` when the ASCII version of the function is required on z/OS. This depends on: eclipse-omr/omr#8017 Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
Deigue
added a commit
to Deigue/omr
that referenced
this pull request
Nov 17, 2025
Contributor
|
jenkins build all |
babsingh
approved these changes
Nov 18, 2025
Deigue
added a commit
to Deigue/openj9
that referenced
this pull request
Nov 19, 2025
OMR_ISSPACE is a macro that provides a more flexible implementation to find spaces for a given parameter. It will conditionally use the BIMODAL function `__isspace_a()` when the ASCII version of the function is required on z/OS. This depends on: eclipse-omr/omr#8017 Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
annaibm
pushed a commit
to annaibm/openj9
that referenced
this pull request
Mar 19, 2026
OMR_ISSPACE is a macro that provides a more flexible implementation to find spaces for a given parameter. It will conditionally use the BIMODAL function `__isspace_a()` when the ASCII version of the function is required on z/OS. This depends on: eclipse-omr/omr#8017 Signed-off-by: Gaurav Chaudhari <Gaurav.Chaudhari@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces usage of
isspace()withOMR_ISSPACE()This conditionally uses
__isspace_a()on z/OS platforms, to properly handle ASCII input.