Disable opts under -Xtune:throughput - #7928
Merged
Merged
Conversation
Contributor
Author
|
Jenkins build all This contribution is wholly within an existing J9 |
Contributor
Author
|
@vijaysun-omr : please review |
vijaysun-omr
approved these changes
Sep 11, 2025
Contributor
|
Simple enough, but will ask for review from @mpirvu |
Contributor
|
fyi @hzongaro |
Contributor
|
I think it's worth adding a comment, both in the commit description and in the code, saying why we are doing this. |
Certain optimizations may work against overall throughput goals because the transformations may yield artifacts (e.g., stack local objects, increased internal pointers usage) that put pressure on method prologues for applications that may have large acyclic methods and reach higher optimization levels. In addition, they have the potential to create improper regions which inhibit other throughput-focused optimizations. The guarded optimizations are: * loop strider * loop replicator * escape analysis * loop transfer Signed-off-by: Daryl Maier <maier@ca.ibm.com>
0xdaryl
force-pushed
the
tunethroughputdisable
branch
from
September 12, 2025 11:56
f8b992f to
32aebc9
Compare
Contributor
Author
|
Updated comment only. Re-running CI is not necessary. |
Contributor
|
Only the commit message changed, so I won't run tests again. |
Contributor
Author
|
To be clear, I added a comment in the code and updated the commit message. CI wasn't necessary for either. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain optimizations may work against overall throughput goals because the transformations may yield artifacts (e.g., stack local objects, increased internal pointers usage) that put pressure on method prologues for applications that may have large acyclic methods and reach higher optimization levels. In addition, they have the potential to create improper regions which inhibit other throughput-focused optimizations.
The guarded optimizations are: