Accommodate the long-future Power processors gracefully - #7899
Merged
Conversation
Contributor
Author
|
@babsingh please review/approve/merge |
babsingh
reviewed
Aug 21, 2025
| } else if (0 == strncasecmp(processorName, "power11", 7)) { | ||
| rc = OMR_PROCESSOR_PPC_P11; | ||
| } else if (0 == strncasecmp(processorName, "power1", 6)) { | ||
| // Punt the long-future anticipated cases to the latest we know |
Contributor
There was a problem hiding this comment.
minor nit, port library doesn't use // for comments ... i have also reworded the comment to improve readability
Suggested change
| // Punt the long-future anticipated cases to the latest we know | |
| /* Defer the long-term anticipated cases to the latest known state. */ |
to the latest we know
Contributor
|
jenkins build plinux |
babsingh
approved these changes
Aug 21, 2025
babsingh
added a commit
to babsingh/omr
that referenced
this pull request
Aug 22, 2025
Related: eclipse-omr#7899 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to the latest we know