Improve definition of HOOK_RECORD() - #7892
Merged
Merged
Conversation
The `event` parameter is unsigned so `-1 - event` isn't strictly appropriate; the equivalent computation, `~(intptr_t)event` avoids mixing signed and unsigned quantities. This avoids (something close to?) undefined behavior which leads the Open XL compiler on z/OS to make unwanted "optimizations". Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Contributor
|
jenkins build all |
Contributor
Author
|
The xlinux builds encountered this: |
Contributor
Author
|
jenkins build linux_x86,linux_x86-64 |
Contributor
|
The relaunch didn't happen; attempting to relaunch the builds once more using aliases. jenkins build x32linux,xlinux |
babsingh
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
eventparameter is unsigned so-1 - eventisn't strictly appropriate; the equivalent computation,~(intptr_t)eventavoids mixing signed and unsigned quantities.This avoids (something close to?) undefined behavior which leads the Open XL compiler on z/OS to make unwanted "optimizations".