x86: Fix (b/s/i/l/v)2m opcodes fp masks - #7752
Merged
Merged
Conversation
Contributor
Author
|
jenkins build all |
Contributor
Author
gita-omr
approved these changes
May 9, 2025
BradleyWood
marked this pull request as draft
May 9, 2025 20:16
Contributor
Author
|
Marking as draft while I investigate an issue |
BradleyWood
marked this pull request as ready for review
May 9, 2025 21:21
hzongaro
reviewed
May 13, 2025
hzongaro
left a comment
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
I think the changes look good. Just one suggestion for a comment.
When converting boolean array to lanewise bitmask a subtraction op is used to set all bits to 0 or 1. The sub opcode must be integral even when the mask element type is floating-point. Signed-off-by: Bradley Wood <bradley.wood@ibm.com>
Contributor
|
Jenkins build all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When converting boolean array to lanewise bitmask a subtraction op is used to set all bits to 0 or 1. The sub opcode must be integral even when the mask element type is floating-point.