Ensure simplification of compare op is valid - #7712
Merged
Merged
Conversation
hzongaro
reviewed
Apr 7, 2025
kevindean12
force-pushed
the
unsigned-cmp-sel
branch
from
April 7, 2025 18:20
f43ed4c to
103a185
Compare
hzongaro
reviewed
Apr 7, 2025
Removes isUnsignedCompare from the call to TR::ILOpcode::compareOpCode since the comparison to be made is one for inequality. The signedness of the integer comparison makes no difference in this case. This prevents unnecessarily returning a BadILOp from compareOpCode(), as would previously have been done for most unsigned comparisons. Also adds a check for a BadILOp to ensure that in all future cases the compare op is a valid IL op before proceeding with simplification.
kevindean12
force-pushed
the
unsigned-cmp-sel
branch
from
April 8, 2025 11:25
103a185 to
f6306ee
Compare
Contributor
|
Jenkins build all |
Contributor
|
risc-v testing has been timing out consistently for the past few weeks, so I won't wait for this test run to complete. All other testing was successful. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the compare op is an unsigned compare, unless the select op's DataType is TR::Address, simplifyISelectCompare() will recreate the compare op with a BadILOp because compareOpCode() will not find a valid comparison op of type TR_cmpNE. This will cause problems in the comparison op simplifier afterward. Guards against this simplification in these cases.