Move mask overlap check from omrgcconsts.h to ForwardedHeader.hpp - #7629
Merged
Conversation
The latter (a C++ header file) cannot be included in the former (which must be usable in C source files), and it's not reasonable to assume that the latter is always included before the former. ForwardedHeader.hpp is included in ForwardedHeader.cpp (and other compilation units) so the check is guaranteed to be done. Add missing parentheses. Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Contributor
|
@amicic or @dmitripivkine could you review this PR? |
amicic
approved these changes
Jan 27, 2025
Contributor
|
jenkins build all |
babsingh
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latter (a C++ header file) cannot be included in the former (which must be usable in C source files), and it's not reasonable to assume that the latter is always included before the former.
ForwardedHeader.hppis included inForwardedHeader.cpp(and other compilation units) so the check is guaranteed to be done.Add missing parentheses.