Skip to content

Fix several issues in omrfiletext.c - #7606

Merged
babsingh merged 1 commit into
eclipse-omr:masterfrom
keithc-ca:filetext
Jan 15, 2025
Merged

Fix several issues in omrfiletext.c#7606
babsingh merged 1 commit into
eclipse-omr:masterfrom
keithc-ca:filetext

Conversation

@keithc-ca

Copy link
Copy Markdown
Contributor
  • avoid use of free'd memory
  • avoid unnecessary (repeated) calls to strlen()
  • update for coding standard

@keithc-ca
keithc-ca requested a review from babsingh as a code owner January 14, 2025 19:12
@keithc-ca

Copy link
Copy Markdown
Contributor Author

@babsingh Could you please review this? Thanks.

Comment thread port/win32/omrfiletext.c Outdated
Comment thread port/win32/omrfiletext.c Outdated
Comment thread port/win32/omrfiletext.c Outdated
* avoid use of free'd memory
* avoid unnecessary (repeated) calls to strlen()
* update for coding standard

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@babsingh

Copy link
Copy Markdown
Contributor

jenkins build all

@keithc-ca

Copy link
Copy Markdown
Contributor Author

10:56:03 All nodes of label compile:zos are offline

@babsingh

Copy link
Copy Markdown
Contributor

@AdamBrousseau Will it be possible to get the z/OS machines online?

@babsingh babsingh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging. If z/OS related issues are seen in upstream builds, we can address them later.

@babsingh
babsingh merged commit cb5c80c into eclipse-omr:master Jan 15, 2025
@keithc-ca
keithc-ca deleted the filetext branch January 15, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants