Skip to content

Add sysinfo_get_number_context_switches() - #7580

Merged
babsingh merged 1 commit into
eclipse-omr:masterfrom
thallium:context-switches
Dec 11, 2024
Merged

Add sysinfo_get_number_context_switches()#7580
babsingh merged 1 commit into
eclipse-omr:masterfrom
thallium:context-switches

Conversation

@thallium

@thallium thallium commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

Added a function to retrieve the number of context switches in the OMR
port library. Also, added a basic functional test for the new function.
This is needed for JFR ThreadContextSwitchRate event.

thallium added a commit to thallium/openj9 that referenced this pull request Dec 2, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
Comment thread fvtest/porttest/si.cpp
Comment thread port/unix/omrsysinfo.c
Comment thread port/unix/omrsysinfo.c Outdated
Comment thread port/unix/omrsysinfo.c
Comment thread port/unix/omrsysinfo.c
Comment thread port/common/omrsysinfo.c Outdated
@thallium

thallium commented Dec 3, 2024

Copy link
Copy Markdown
Contributor Author

@babsingh Addressed your comments

Comment thread port/unix/omrsysinfo.c Outdated
Comment thread fvtest/porttest/si.cpp Outdated
@babsingh

babsingh commented Dec 3, 2024

Copy link
Copy Markdown
Contributor
  • Squash the commits since the changes are related to each other. Independent standalone changes can be in separate commits. In this case, if the first commit is reverted, the other commit will also need to be reverted.
  • Add a description in the commit message summarizing the changes: Added a function to retrieve the number of context switches in the OMR port library. Also, added a basic functional test for the new function. This is needed for .... At first glance, a reader should be able to grasp the intent/scope/justification for the PR before looking/reviewing the code changes.

@babsingh

babsingh commented Dec 3, 2024

Copy link
Copy Markdown
Contributor

jenkins build all

thallium added a commit to thallium/openj9 that referenced this pull request Dec 4, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 6, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@babsingh

babsingh commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

@thallium Can you provide an update on the issues that were encountered on Windows?

Added a function to retrieve the number of context switches in the OMR
port library. Also, added a basic functional test for the new function.
This is needed for JFR ThreadContextSwitchRate event.

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@thallium

thallium commented Dec 9, 2024

Copy link
Copy Markdown
Contributor Author

Can you provide an update on the issues that were encountered on Windows?

it was failing because of eclipse-openj9/openj9#20158 and I was working on fixing those implicit conversions. Should be able to get a successful build on Windows today.

thallium added a commit to thallium/openj9 that referenced this pull request Dec 9, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 9, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 9, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@thallium

Copy link
Copy Markdown
Contributor Author

@babsingh

Copy link
Copy Markdown
Contributor

jenkins build all

@babsingh

Copy link
Copy Markdown
Contributor

Windows and RISC failures are CI/infra related.

@AdamBrousseau fyi, Previously, only RISC-V builds were failing. Now, Windows builds are failing as well. Also, why the Azure builds no longer run?

@babsingh
babsingh merged commit f7fb69c into eclipse-omr:master Dec 11, 2024
thallium added a commit to thallium/openj9 that referenced this pull request Dec 11, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
@AdamBrousseau

Copy link
Copy Markdown
Contributor

Windows builds are failing as well. Also, why the Azure builds no longer run?

Known. Should be resolved soon.
Not sure about the Azure builds. I'm not as familiar with them so I'm not sure what is supposed to be running.

@babsingh

Copy link
Copy Markdown
Contributor

@0xdaryl Do you know why the Azure builds have stopped running?

thallium added a commit to thallium/openj9 that referenced this pull request Dec 11, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 12, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 12, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 12, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
thallium added a commit to thallium/openj9 that referenced this pull request Dec 30, 2024
Depends on: eclipse-omr/omr#7580

Signed-off-by: Gengchen Tuo <gengchen.tuo@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants