Zero offheap on commit on OSX - #7559
Merged
babsingh merged 1 commit intoNov 26, 2024
Merged
Conversation
amicic
changed the title
babsingh
reviewed
Nov 26, 2024
amicic
force-pushed
the
zero_offheap_on_commit_on_osx
branch
from
November 26, 2024 14:35
7f2f732 to
bcb4b24
Compare
dmitripivkine
approved these changes
Nov 26, 2024
babsingh
reviewed
Nov 26, 2024
For some reason OSX does not seem to zero memory on commit, unless it's the first commit. For now, till we understand if there is a way to force zero on subsequent re-commits, we will zero it explicitly. Including zPTF as well, since we don't know how it will behave, even if/when it adds support for commit/decommit/virtual-memory. Signed-off-by: Aleksandar Micic <Aleksandar_Micic@ca.ibm.com>
amicic
force-pushed
the
zero_offheap_on_commit_on_osx
branch
from
November 26, 2024 14:49
bcb4b24 to
9e83ee1
Compare
Contributor
|
jenkins build all |
babsingh
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason OSX does not seem to zero memory on commit, unless it's
the first commit. For now, till we understand if there is a way to force
zero on subsequent re-commits, we will zero it explicitly.
Including zPTF as well, since we don't know how it will behave, even
if/when it adds support for commit/decommit/virtual-memory.