Remove compiler ras address masking

[0xdaryl]

"Address masking" was an attempt to make compiler log files easier to compare by preventing addresses (that are likely to change between compilations) from being printed raw in a compilation log. It worked by intercepting the "printf" family of IO functions and checking whether any addresses were being printed with the %p format specifier, and instead of printing the address a "Masked Address" string was substituted instead.

This feature was introduced at a time when text file comparison tools were not as robust as they are today and many addresses are output to the log without using %p making this feature less effective. Since it adds overhead and complexity to the logging path, has incomplete coverage, and is not widely used (if at all), remove it from the code base.

Removing address masking was discussed briefly at the Oct 24 OMR Architecture Meeting with agreement to remove it.

[0xdaryl]

@JBKingdon @klangman : FYI for any opinions you might have

[0xdaryl]

@dsouzai : would you mind reviewing please?

[JamesKingdon]

Sounds good to me.

[dsouzai]

Overall LGTM aside from a couple of comments.

[dsouzai]

jenkins build all

[dsouzai]

win build failure:

[2024-11-19T14:41:35.197Z]          Debug.cpp
[2024-11-19T14:41:36.525Z]     32>c:\omr\workspace\pullrequest-win_x86-64\build\compiler\ras\debug.cpp(531): error C2220: warning treated as error - no 'object' file generated [C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj]
[2024-11-19T14:41:36.525Z]     32>c:\omr\workspace\pullrequest-win_x86-64\build\compiler\ras\debug.cpp(531): warning C4101: 'buffer': unreferenced local variable [C:\omr\workspace\PullRequest-win_x86-64\Build\build\jitbuilder\jitbuilder.vcxproj]

I guess TR_Debug::vtrace(const char * format, va_list args) initializes char buffer[256]; which isn't used anymore.

[0xdaryl]

Jenkins build all