Add option for per-compilation dependency tracking - #7539
Merged
Conversation
The TR_DisableDependencyTracking option disables dependency tracking and dependency-based loading for individual methods. In OpenJ9, dependency tracking will still be disabled unconditionally if -XX:-TrackAOTDependencies is set. Signed-off-by: Christian Despres <despresc@ibm.com>
Contributor
Author
|
Attn @mpirvu. |
dsouzai
approved these changes
Nov 11, 2024
Contributor
|
jenkins build all |
mpirvu
reviewed
Nov 11, 2024
mpirvu
left a comment
mpirvu
left a comment
Contributor
There was a problem hiding this comment.
Why do we need TR_DisableDependencyTracking if we have -XX:-TrackAOTDependencies?
Contributor
Author
|
It's not strictly necessary. When I was working on the feature I had a per-compilation flag that controlled whether or not dependencies were gathered during a fresh AOT compilation, and that flag was separate from the option to maintain the dependency table itself. I haven't really needed it, but these options could be used for debugging, to exclude certain methods from being stored with dependencies, or from being loaded based on dependency. There could just be the one |
mpirvu
approved these changes
Nov 11, 2024
Contributor
|
osx failure due to #6516 merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TR_DisableDependencyTracking option disables dependency tracking and dependency-based loading for individual methods. In OpenJ9, dependency tracking will still be disabled unconditionally if -XX:-TrackAOTDependencies is set.
Related: eclipse-openj9/openj9#20529