Recognize POWER11 on Linux - #7528
Merged
Merged
Conversation
Contributor
Author
|
@babsingh please review/approve/merge |
babsingh
reviewed
Nov 6, 2024
babsingh
left a comment
babsingh
left a comment
Contributor
There was a problem hiding this comment.
- The code LGTM.
- Is
AT_PLATFROM -> AT_PLATFORMa typo in the PR description and commit message? - I will also recommend to avoid first person:
we. Here is a rewrite:The recognition mechanism involves comparing it with AT_PLATFORM.
"power11" patch for Linux kernel was upstreamed a couple months ago. the recognition mechanism involves comparing it with AT_PLATFORM. Signed-off-by: Julian <zlwang@ca.ibm.com>
Contributor
|
jenkins build all |
Contributor
|
jenkins build plinux,zlinux |
2 similar comments
Contributor
|
jenkins build plinux,zlinux |
Contributor
|
jenkins build plinux,zlinux |
babsingh
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"power11" patch for Linux kernel was upstreamed a couple months ago. the
recognition mechanism involves comparing it with AT_PLATFORM.