Recognize POWER11 and future coverage on AIX - #7522
Conversation
|
@dsouzai please review/approve/merge |
|
jenkins build all |
| } else if (__power_latestKnownAndUp()) { | ||
| desc->processor = OMR_PROCESSOR_PPC_P11; |
There was a problem hiding this comment.
Wouldn't this change incorrectly mark Power12+ processors as Power11 once newer versions are introduced, leading the API to provide misleading information? Wouldn't using OMR_PROCESSOR_PPC_UNKNOWN be a better and more accurate alternative instead of providing incorrect information?
There was a problem hiding this comment.
you can refer as pFuture ... the naming cannot be used until IBM uses it publicly, in case IBM changes the naming.
OMR_PROCESSOR_PPC_UNKNOWN is exactly the wrong thing to do here. __power_latestKnownAndUp() was exactly defined to address this existing problem: OMR_PROCESSOR_PPC_UNKNOWN makes us not able to exploit processor features (we are forced to using common set of ISA from 25 years ago). this fix at least allows us to use features available in POWER11.
There was a problem hiding this comment.
Makes sense. Once Power12 or pFuture is introduced, we will have to update it again. Do we have an issue open to track follow up changes to this method? If not, we should open one and link it to this PR; it will make it easy to track future work.
There was a problem hiding this comment.
given IBM Infrastructure currently expected cadence of POWER processor refresh, it will be a long-drawn-out issue (we can discuss the details offline). Furthermore, we will naturally be required to do it by our main runtime stakeholder anyway.
| } else if (__power_latestKnownAndUp()) { | ||
| desc->processor = OMR_PROCESSOR_PPC_P11; |
There was a problem hiding this comment.
Makes sense. Once Power12 or pFuture is introduced, we will have to update it again. Do we have an issue open to track follow up changes to this method? If not, we should open one and link it to this PR; it will make it easy to track future work.
POWER11 recognition macro is defined before it is officially available from AIX system header files. A catch-all macro for future processors is defined as well. Signed-off-by: Julian <zlwang@ca.ibm.com>
|
jenkins build all |
3 participants
POWER11 recognition macro is defined before it is officially available from AIX system header files. A catch-all macro for future processors is defined as well.