Accelerate Unsafe CAS Intrinsics on Aarch64 - #7505
Merged
Merged
Conversation
Support for acceleration of compareAndExchange[Int|Long|Reference] has been extended to Arm. As a result, the check in callDoesAnImplicitAsyncCheck needs to be updated as well. Cleans up isUnsafeCAS and isUnsafeWithObjectArg to remove unused comp parameter. Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
IBMJimmyk
requested review from
0xdaryl,
mstoodle and
vijaysun-omr
as code owners
October 29, 2024 15:55
Contributor
Author
|
@hzongaro When you get the chance, could you look over these common changes? |
hzongaro
requested review from
hzongaro
and removed request for
0xdaryl,
mstoodle and
vijaysun-omr
October 29, 2024 17:12
hzongaro
approved these changes
Oct 29, 2024
hzongaro
left a comment
hzongaro
left a comment
Contributor
There was a problem hiding this comment.
I think these changes look good. Thanks!
Contributor
|
Jenkins build all |
knn-k
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for acceleration of
compareAndExchange[Int|Long|Reference]has been extended to Arm. As a result, the check incallDoesAnImplicitAsyncCheckneeds to be updated as well.Cleans up
isUnsafeCASandisUnsafeWithObjectArgto remove unused comp parameter.Needs to be check in with:
eclipse-openj9/openj9#20432
Due to the changes to the parameters of
isUnsafeCASandisUnsafeWithObjectArg.