Add the correct address as ClassUnloading PicSite in POWER LE - #7487
Merged
Conversation
Contributor
Author
zl-wang
approved these changes
Oct 9, 2024
zl-wang
left a comment
zl-wang
left a comment
Contributor
There was a problem hiding this comment.
LGTM. you need to push this fix to 0.48 branch as well though
Contributor
|
Jenkins build aix,plinux |
POWER patches class unload constants by `address |= 1` of a 32bit value given it might be an instruction, to correctly invalidate the constant we offset the `acursor` differently for LE and BE to overwrite the least-significant bit in the constant. Signed-off-by: Abdulrahman Alattas <rmnattas@gmail.com>
rmnattas
force-pushed
the
ppcle-picoffset
branch
from
October 10, 2024 19:40
cf78ae2 to
4867804
Compare
Contributor
Author
|
Wrapping the addition before the casting for the AIX compiler |
Contributor
|
Jenkins build aix,plinux |
0xdaryl
approved these changes
Oct 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POWER patches class unload constants by
value |= 1of a 32bit value given it might be an instruction, to correctly invalidate the constant we offset theacursordifferently for LE and BE to overwrite the least-significant bit in the constant.Closes eclipse-openj9/openj9#20263
Maybe eclipse-openj9/openj9#20261 Closed
Maybe eclipse-openj9/openj9#19884 Closed