Fix OpenXL Warnings - #7445
Conversation
40edfce to
43e1560
Compare
ee19aac to
7dd1f72
Compare
|
@r30shah please review |
7dd1f72 to
6c928ca
Compare
r30shah
left a comment
r30shah
left a comment
There was a problem hiding this comment.
LGTM. @matthewhall2 can you add more context to commits in this PR ?
6c928ca to
a189074
Compare
done |
|
@hzongaro Can I request you to review and merge this PR ? |
|
Jenkins build all |
|
Not sure what happened, but I can not get the builds through comment here, Would need Henry's help for that as well |
hzongaro
left a comment
hzongaro
left a comment
There was a problem hiding this comment.
I think the changes look correct.
May I ask you adjust the summary line of the first commit from "Intialized uninitialized variables" to "Intialize uninitialized variables"? The commit guidelines require the first line to be written in imperative mood.
fixes "unitialized variable" warnings on openxl Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
fixes warning "assignment inside if clause" in openxl Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
fixes "enumeration values ...." not handled warnings on openxl Signed-off-by: Matthew Hall <matthew.hall3@outlook.com>
a189074 to
b2fa915
Compare
|
Jenkins build all |
Builds did not begin for me either. I'm wondering whether it has something to do with the migration from eclipse/omr to eclipse-omr/omr. . . . |
|
Jenkins build all |
|
Looks like the builds are happening, but they're not reflected here. |
|
jenkins build aarch64 |
1 similar comment
|
jenkins build aarch64 |
|
Jenkins build all |
|
Windows failure appears to be an infrastructure problem. Rerunning. Jenkins build win |
4 participants
Suppresses warnings when building on OpenXL
Warnings:
https://hyc-runtimes-jenkins.swg-devops.com/job/jvm.29.personal/34234/