x86-64: Select REP MOVS instruction based on CPU for char arraycopy - #7442
Merged
0xdaryl merged 1 commit intoAug 21, 2024
Conversation
Use `rep movsw` to copy multiple of 2 bytes for copy size greater than the threshold (32 bytes), which performs better than `rep movsd` for CascadeLake and later CPUs. Setting env variable `TR_UseREPMOVSWFor16BitPrimitiveArrayCopy` forces to use `rep movsw`. Setting env variable `TR_UseREPMOVSDFor16BitPrimitiveArrayCopy` forces to use `rep movsd`. Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
Contributor
Author
|
@0xdaryl May I ask you to review this change? Thank you! |
0xdaryl
reviewed
Aug 21, 2024
Contributor
|
Jenkins build xlinux,xmac |
0xdaryl
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
rep movswto copy multiple of 2 bytes for copy size greater than the threshold (32 bytes), which performs better thanrep movsdfor CascadeLake and later CPUs.Setting env variable
TR_UseREPMOVSWFor16BitPrimitiveArrayCopyforces to userep movsw.Setting env variable
TR_UseREPMOVSDFor16BitPrimitiveArrayCopyforces to userep movsd.