Update node uncommoning for offHeap - #7437
Merged
Merged
Conversation
Include dataAddr pointer check with ArrayRef check when unocmmoning a node. Previously, only aiadd or aladd could be used for array access but with offHeap, dataAddr pointer nodes (aloadi) can also be used for array access. Hence we must check for dataAddr pointer and ArrayRef when uncommoning a node. Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
Contributor
Author
Contributor
|
@VermaSh Can you add bit more context for second commit? |
VermaSh
force-pushed
the
setPinningArrayPointer_fix
branch
from
August 8, 2024 21:04
2f4efcb to
24c28dd
Compare
Contributor
Author
|
@r30shah I have updated the commit description. |
The check is needed because simply returning 5th element could result in garbage being returned as pinning array pointer. Returning non null pinning array pointer when it wasn't set can lead to runtime failures. Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
VermaSh
force-pushed
the
setPinningArrayPointer_fix
branch
from
August 8, 2024 21:08
24c28dd to
1fa94fd
Compare
Contributor
|
jenkins build all |
0xdaryl
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include dataAddr pointer check with ArrayRef check when unocmmoning
a node.
Previously, only aiadd or aladd could be used for array access but with
offHeap, dataAddr pointer nodes (aloadi) can also be used for array access.
Hence we must check for dataAddr pointer and ArrayRef when uncommoning a node.
Signed-off-by: Shubham Verma shubhamv.sv@gmail.com