Fix builtin __gdsa function call for Open XL - #7419
Merged
Merged
Conversation
Contributor
|
jenkins build zos |
babsingh
reviewed
Sep 17, 2024
Contributor
There was a problem hiding this comment.
there is only one instance of ifdefs being commented at the end of this file. the suggested formatting in the coding standard should be followed: https://github.com/eclipse/omr/blob/3223d8d0d584575eafb5ec462250baae92cd6084/doc/CodingStandard.md#comment-conditional-compilation-directives-if-ifdef-ifndef-else-elif-endif
Deigue
force-pushed
the
openxl-fixbuiltin
branch
2 times, most recently
from
October 21, 2024 17:45
4531d0c to
b48a74e
Compare
When building Open J9, Open XL throws an error building CallStack.cpp as extern builtins unsupported. This adds the appropriate alternative that works with Open XL and allows compilation. Signed-off-by: Gaurav Chaudhari <gaurav.chaudhari@ibm.com>
Deigue
force-pushed
the
openxl-fixbuiltin
branch
from
October 21, 2024 17:50
b48a74e to
0ace93f
Compare
Contributor
|
jenkins build all |
babsingh
approved these changes
Oct 22, 2024
babsingh
left a comment
babsingh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Ignoring the AIX failure; all AIX nodes are offline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building Open J9, Open XL throws an error building CallStack.cpp as extern builtins unsupported. This adds the appropriate alternative that works with Open XL and allows compilation.